add device.x for riscv targets, and provides __EXTERNAL_INTERRUPTS #527
Conversation
…_INTERRUPTS vector table in pacs for device specific interrupt management
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
|
( i'm unable to test with |
|
Looks good in first view. Add this to changelog, please. cc @Disasm |
We did not use |
|
move text in changelog under |
|
sorry, there you go |
This PR is a proposal to address #526 .
__EXTERNAL_INTERRUPTSis the symbol used since__INTERRUPTSis used by riscv-rtI think it fits because the peripheral interrupts are supposed to be pending through the external interrupt.
This provides hals with information to manage interrupt request. either through a PLIC or trough the vectored interrupt when that is implemented (in riscv-rt i suppose).
Remarks welcome