Add Vec::drain and String::drain.
#444
Conversation
|
could you add tests? |
src/vec/drain.rs
Outdated
| pub(super) tail_len: usize, | ||
| /// Current remaining range to remove | ||
| pub(super) iter: slice::Iter<'a, T>, | ||
| pub(super) vec: NonNull<Vec<T, N>>, |
There was a problem hiding this comment.
If this was built on top of #425 this would allow removing the const N: usize generic, and replace the pointer with NonNull<VecView<T>>. #425 does not offer the View functionality for String to keep the PR small, but it would be easy to add it.
It is worth considering because merging this PR and releasing before merging #425 would make it a breaking change to remove the const generic, so there would need to be 2 implementation of drain, one for the view and one for the owned type.
There was a problem hiding this comment.
Yes, I agree it makes sense to base this on VecView instead.
reitermarkus
force-pushed
the
drain
branch
3 times, most recently
from
d342c97
to
49e98f2
Compare
|
I can't quite figure out the |
reitermarkus
force-pushed
the
drain
branch
3 times, most recently
from
29e1279
to
7d96cd2
Compare
|
rebased it for you on top of the new VecView impl. |
|
@Dirbaio, thanks! |
Closes #334 and #365.