Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Functions can accept Javascript objects #734

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

JS Functions can accept Javascript objects #734

wants to merge 18 commits into from
+441 −45

Conversation

ambiguousname
Copy link
Member

@ambiguousname ambiguousname commented Nov 21, 2024 •
edited
Loading

Fixes #720.

TODO:

  • Add test for nested struct construction
  • Don't think nested structs are actually recognized yet. Need to update struct construction code to fix this.
  • Label parameters correctly in typescript
  • StructTypeName_Obj with recursive structs also need StructTypeName | StructTypeName_Obj labeling in typescript

@ambiguousname ambiguousname added the B-js JS backend label Nov 21, 2024
Manishearth
Manishearth approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wodner if we should also make this clear in the typescript types or let it be under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
B-js JS backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS2 constructors: structs and enums should autoconvert at parameter/struct boundaries
2 participants
@ambiguousname @Manishearth