Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non_exhaustive everywhere #342

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add non_exhaustive everywhere #342

merged 3 commits into from
Sep 21, 2023

Conversation

Manishearth
Copy link
Contributor

we shouldn't have to make a breaking change each time

@Manishearth Manishearth requested a review from sffc September 21, 2023 22:36
@Manishearth Manishearth force-pushed the nonex branch 2 times, most recently from f86a2d3 to e8e9720 Compare September 21, 2023 22:49
sffc
sffc approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but please file an issue to make the lint required on CI.

@Manishearth Manishearth mentioned this pull request Sep 21, 2023
Open
@Manishearth
Copy link
Contributor Author

#343

@Manishearth Manishearth merged commit e3daa69 into rust-diplomat:main Sep 21, 2023
5 checks passed
@Manishearth Manishearth deleted the nonex branch September 21, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @sffc