Book: First draft of signals chapter #105
Conversation
|
r? @stjepang I tried to keep it simple for now, and hope it's still correct. What more do I need to mention to make this really useful? |
|
@vorner Just pinging you in case you'd like to take a look. |
|
Thanks so much for the super fast reviews, @Screwtapello and @stjepang! <3 |
|
Let's land it! As always, comments here and on #58 are welcome even after the merge! |
| let ticks = tick(Duration::from_secs(1)); | ||
|
|
||
| loop { | ||
| select! { |
There was a problem hiding this comment.
This is the select macro from crossbeam-channels, which I think is still going strong
There was a problem hiding this comment.
This is crossbeam_channel::select!, not std::select! (which is deprecated).
| for example to close network connections, | ||
| remove temporary files, | ||
| or reset system settings, | ||
| this chapter is however very relevant! |
There was a problem hiding this comment.
Is this a good place to point out one should still be able to cope with non-clean shutdown somehow (machine crash, sigkill, crash of program), like cleaning up the temporary files on the next start?
There was a problem hiding this comment.
Oh, that's very a interesting point! I can add a short paragraph here, but maybe it would make more sense to add a full chapter on "writing robust CLI applications". What do you think?
There was a problem hiding this comment.
The other chapter probably sounds better (and it probably is not specific to CLI only). Still, as a wording nitpick, maybe not call it „cleanup“, but „graceful shutdown“? Like, the OS will terminate network connections, but it might happen in the middle of a message instead of after saying proper „Good bye“.
There was a problem hiding this comment.
Thanks! Expanded the note to describe graceful shutdown scenarios, and opened #107 for tracking ideas around a "robustness" chapter.
Closes #50
cc #27