update libsecp to latest ersion; bump major version number #384
Conversation
There was a problem hiding this comment.
utACK 6950253 I inspected the rust changes but I haven't reproduced the C subtree
| base_config.file("depend/secp256k1/contrib/lax_der_parsing.c") | ||
| .file("depend/secp256k1/src/precomputed_ecmult_gen.c") | ||
| .file("depend/secp256k1/src/precomputed_ecmult.c") |
There was a problem hiding this comment.
note: In upstream, we compile these to a separate object which is then linked to the actual library code. This saves compilation time in the common case that the code has changed but tables haven't. But it's probably not worth the hassle here because we never touch the C code here, not even during development.
|
Is this ready to be merged to unblock miniscript progress towards taproot? (see rust-bitcoin/rust-miniscript#292 for details) |
apoelstra
force-pushed
the
2022-01--secp-update
branch
from
6950253
to
a7bb5fb
Compare
|
Rebased. But we still don't have #390 in. |
|
Do we plan to change MSRV already or is it intended for later release? |
|
@Kixunil later release. I'd like to get this major release into the upcoming rust-bitcoin major release, so I'm trying to keep it small (just new version of upstream and fixed |
|
OK, will change #403 to not require MSRV bump. |
apoelstra
force-pushed
the
2022-01--secp-update
branch
from
a7bb5fb
to
9a0cf1f
Compare
|
Rebased. Remaining:
|
|
Let's leave it out, thanks for asking. |
Is it? One of my PRs did just that and nobody complained. :) |
|
@Kixunil just in |
|
Yes, OK. |
|
Would like to get #410 in as well |
Two API changes needed to be reflected: schnorrsig_sign and schnorrsig_verify. Also bump both Cargo.toml files
…CHECK We can no longer produce non-verification context objects, so instead produce an invalid public key.
6bcf3ea Add bitcoin-hashes-std features (Tobin Harding) 555833b Disable bitcoin_hashes default features (Tobin Harding) b6f169f Improve manifest whitespace (Tobin Harding) Pull request description: Currently we use default features for the `bitcoin_hashes` dependency, doing so breaks the `no-std` feature in `rust-bitcoin` because `std` is part of `bitcoin_hashes` default feature set. Disable `bitcoin_hashes` default features, no changes to `rust-bitcoin` are require after this change since we manually turn on `std` and `alloc` as part of the `std`/`no-std` features of `rust-bitcoin`. For other users of `rust-secp256k1` this is a breaking change but is unlikely to cause too much bother because `std` is so commonly used. This PR resolves an open [issue](#384) in `rust-bitcoin`, see issue for discussion. ACKs for top commit: apoelstra: ACK 6bcf3ea Tree-SHA512: 3cb83b67ba73b096f05cb5c98e1057c34cbf75208c626830a9c5050d3927c7dc6c13109e43c01701b1dfa7adfcfb6745bae6501f903be5976f6d1534fa9b3598
apoelstra
force-pushed
the
2022-01--secp-update
branch
from
9a0cf1f
to
7fd7cba
Compare
apoelstra
force-pushed
the
2022-01--secp-update
branch
from
7fd7cba
to
aa51638
Compare
|
Rebased; added changelog; this is ready to go. @elichai and/or @real-or-random can you ACK this? |
There was a problem hiding this comment.
ACK aa51638 I can't judge if the feature set is meaningful but this release PR is fine
|
Thanks for this @real-or-random. This release would give us static contexts that help a lot in terms of code hygiene for downstream projects. |
Should wait on merging until we get a minor release out with #382 and #376.
May also want to bundle #380 with this?