Support multiple warnings in RPC responses #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcharding would it please be possible to include #353 & #356 in the upcoming release PR? |
0xB10C
added a commit
to 0xB10C/fork-observer
that referenced
this pull request
Sep 26, 2024
and rust-bitcoin-pool-indentification 0.3.3 -> 0.3.4. bitcoincore-rpc 0.19 is needed for full Bitcoin Core >=28.x support. The getnetworkinfo RPC call now returns a list of warnings instead of a single warning String. This would cause fork-observer to fall back to "unkown version" as mapping the JSON response would fail. See rust-bitcoin/rust-bitcoincore-rpc#356
0xB10C
added a commit
to 0xB10C/fork-observer
that referenced
this pull request
Sep 26, 2024
and rust-bitcoin-pool-indentification 0.3.3 -> 0.3.4. bitcoincore-rpc 0.19 is needed for full Bitcoin Core >=28.x support. The getnetworkinfo RPC call now returns a list of warnings instead of a single warning String. This would cause fork-observer to fall back to "unkown version" as mapping the JSON response would fail. See rust-bitcoin/rust-bitcoincore-rpc#356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #352 & #353.
Tested on latest bitcoind (bitcoin/bitcoin@2cedb42) with latest electrs (romanz/electrs@7773c26).