Revert "Merge rust-bitcoin/rust-bitcoincore-rpc#326: Replace Signatur… #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
May 5, 2024
|
I'm going to merge this with the MSRV job red because |
|
Hey @tcharding Just so I understand correctly, #326 was reverted and is broken because of the need to support base64 and supporting base64 would need Steven's ACK which might take a while so it wasn't worth it? Pardon if i misunderstood, might have gotten lost in the weeds. |
|
@masud-abdulkadir correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e with Message Signature"
This reverts commit 05f5b82, reversing changes made to c0fc7cb.
#326 was broken, I should never have merged it. It also should never have gotten past CI. All blame falls on me.