Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.28 RC1 #789

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Release v0.28 RC1 #789

merged 1 commit into from
Jan 18, 2022

Conversation

dr-orlovsky
Copy link
Collaborator

We still have quite a few issues and PRs pending to be addressed/merged before full 0.28 release: see https://github.com/rust-bitcoin/rust-bitcoin/milestone/10

Most important, we have to find a way to address #777; additionally it will be desirable to get #587, #786, #776.

We also have quite of work to write CHANGELOG in #785

Nevertheless I propose to start with a beta-1 subrelease to unlock ability for miniscript release and downstream testing. The Taproot API looks final, and the pending PRs are addresses internal issues/bugs which is perfectly fine for beta releases.

@dr-orlovsky dr-orlovsky added this to the 0.28.0 milestone Jan 16, 2022
@romanz
Copy link
Contributor

romanz commented Jan 17, 2022 •
edited
Loading

electrs 093f8b6 tACK :)

@apoelstra
Copy link
Member

concept ACK. I'm tempted to bikeshed over "beta" vs "rc".

@tcharding what do you think?

@dr-orlovsky
Copy link
Collaborator Author

Seems like we have all our pending PRs merged so this is indeed an RC release. Updated to the tip of the master and changed to RC in version number. I propose to merge & publish this RC1.

@dr-orlovsky dr-orlovsky changed the title Release v0.28 Beta 1 Release v0.28 RC1 Jan 17, 2022
Kixunil
Kixunil previously approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9efa180

Super happy about this one! :)

Kixunil
Kixunil approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1b2dbd7

@tcharding
Copy link
Member

tcharding commented Jan 17, 2022 •
edited
Loading

concept ACK. I'm tempted to bikeshed over "beta" vs "rc".

lol I did a comment yesterday suggesting rc instead of beta but I seem to have forgotten to hit 'comment'.

@tcharding what do you think?

I don't really mind what the process is as long as I understand it. Currently I do not understand the difference between beta and rc? In this comment @dr-orlovsky you say we do a few beta releases then an rc, whats the benefit of this as opposed to just rc releases please?

@tcharding
Copy link
Member

The diff uses rc now. Pull the trigger @apoelstra!

tcharding
tcharding approved these changes Jan 18, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@tcharding
Copy link
Member

FWIW I've gotten the following downstream crates building.

  • rust-miniscript
  • bdk

Please see branch rust-bitcoin-0.28.0-rc.1 in my trees if you are interested.

We will need #790 for rc 2.

@apoelstra apoelstra merged commit cf8b6ff into rust-bitcoin:master Jan 18, 2022
@apoelstra
Copy link
Member

Tagged and published.

@romanz romanz mentioned this pull request Jan 18, 2022
Merged
RCasatta added a commit to rust-bitcoin/rust-bitcoincore-rpc that referenced this pull request Apr 30, 2022
@RCasatta
Merge #210: Bump 'bitcoin' crate to 0.28.0
79d457d 
e35368f Bump 'bitcoin' crate to 0.28.0 (Roman Zeyde)

Pull request description:

  Following rust-bitcoin/rust-bitcoin#789.

ACKs for top commit:
  sanket1729:
    ACK e35368f
  elichai:
    ACK e35368f
  dunxen:
    ACK e35368f
  RCasatta:
    ACK e35368f

Tree-SHA512: e97b09c220835e3af3e7c844c6275b62a1906919ef57c3017afa939b5d95b769126d5e6133b118e464506815b47f090b9ed59d6fd1ec1c6125a54bec64c3ffac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@tcharding tcharding tcharding approved these changes

@apoelstra apoelstra Awaiting requested review from apoelstra

@RCasatta RCasatta Awaiting requested review from RCasatta

@sanket1729 sanket1729 Awaiting requested review from sanket1729

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dr-orlovsky @romanz @apoelstra @tcharding @Kixunil