Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test bitcoin #72

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

tcharding
Copy link
Member

This branch is not a merge candidate.

Test branch for testing the latest RC release of rust-bitcoin.

Currently we are enabling "rand" using a path dependency in the
dev-dependencies because of the benches. This is reducing coverage in CI
because "std" is always enabled.

Feature gate the bench that requires "rand" and remove the path
dependency.
We use a range dependency for `bitcoin_hashes`, the different allowed
versions each have a different MSRV, which implies using each changes
the MSRV of `bip39`.
@tcharding tcharding force-pushed the test-bitcoin branch 2 times, most recently from 9a6f54e to ee5ce45 Compare April 7, 2024 23:41
We just release a new version of `bitcoin_hashes` which works with
`bip39` with no changes.

Add `bitcoin_hashes v0.14` to the dependency range and document its
effect on the MSRV.

(Note, the "alloc" feature is required as of 0.14).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant