Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update release-please.yml to use v4 #109

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: update release-please.yml to use v4 #109

merged 1 commit into from
Aug 5, 2024

Conversation

dlaehnemann
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10249540825

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.265%
Totals Coverage Status
Change from base Build 10246529013: 0.0%
Covered Lines: 465
Relevant Lines: 735
💛 - Coveralls

@dlaehnemann dlaehnemann requested a review from dcroote August 5, 2024 14:04
dcroote
dcroote approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The prefix could also be ci: but I think fix: is fine too

@dlaehnemann dlaehnemann merged commit fce327c into master Aug 5, 2024
9 checks passed
@dlaehnemann dlaehnemann deleted the fix/update-release-please-to-v4-and-fix-it branch August 5, 2024 15:28
@dlaehnemann
Copy link
Member Author

Ah yeah, good point. I'll remember to use ci: for such changes next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlaehnemann @coveralls @dcroote