Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style fixes #139

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Code style fixes #139

merged 8 commits into from
Apr 16, 2024

Conversation

mschulz-at-hilscher
Copy link
Contributor

@mschulz-at-hilscher mschulz-at-hilscher commented Apr 12, 2024 •
edited
Loading

This PR includes the following fixes:

  • Removes whitespaces from end of lines.
  • Converts indentation from tabs to spaces in *.c and *.h files.
  • References unused variables to get rid of warnings.
  • Uses portable format specifiers from inttypes.h.
  • Uses variable types matching the memcmp_s APIs.
  • Explicitly states which warnings to ignore during tests.

Fixes #138.

@mschulz-at-hilscher
Remove whitespaces from end of line.
49e3429 
Signed-off-by: Matthias Schulz <[email protected]>
@mschulz-at-hilscher
Convert indentation from tabs to 8 spaces per tab to be consistent in…
21cc3de 
… all *.c and *.h files.

Signed-off-by: Matthias Schulz <[email protected]>
@mschulz-at-hilscher
Getting rid of unused variable warnings.
1f9c1e8 
Signed-off-by: Matthias Schulz <[email protected]>
@mschulz-at-hilscher
Use portable format specifiers from inttypes.h.
5d1ee62 
Signed-off-by: Matthias Schulz <[email protected]>
@mschulz-at-hilscher
Use variable types that fit to the memcmp(16|32)_s API.
d1b3cfc 
Signed-off-by: Matthias Schulz <[email protected]>
@mschulz-at-hilscher
Use portable format specifiers from inttypes.h.
b38a047 
Signed-off-by: Matthias Schulz <[email protected]>
@mschulz-at-hilscher
Explicitly state which warnings to ignore in test cases with format s…
d3b41e8 
…trings.

Signed-off-by: Matthias Schulz <[email protected]>
@rurban
Copy link
Owner

rurban commented Apr 12, 2024

Looks good, I'll check tomorrow

@mschulz-at-hilscher
Copy link
Contributor Author

i will send an update on monday. should be the references to unused variables before variable declarations.

@mschulz-at-hilscher
Copy link
Contributor Author

@rurban can you retrigger the tests, please.

@mschulz-at-hilscher
Copy link
Contributor Author

Is the "main" check broken or is there still something wrong in my changes?

@rurban
Copy link
Owner

rurban commented Apr 16, 2024

I think FreeBSD had some recent unrelated changes

@rurban rurban merged commit 97c8b06 into rurban:master Apr 16, 2024
12 of 13 checks passed
@rurban rurban self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rurban rurban rurban approved these changes

Assignees

@rurban rurban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-portable format strings
2 participants
@mschulz-at-hilscher @rurban