Merge pull request #40 from runvs/PerformanceImprovements

Improved network synchronistation between players
runvs · Aug 4, 2023 · b00126a · b00126a
2 parents 5e0a910 + 2dd552d
commit b00126a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/impl/game_common_lib/network_helpers.cpp b/impl/game_common_lib/network_helpers.cpp
@@ -1,12 +1,15 @@
 #include "network_helpers.hpp"
 #include <asio/read.hpp>
 #include <asio/write.hpp>
+#include <performance_measurement.hpp>
 #include <iomanip>
 #include <sstream>
 
 void NetworkHelpers::freeSendString(
     std::string const& str, asio::ip::tcp::socket& socket, jt::LoggerInterface& logger)
 {
+    auto const start = std::chrono::system_clock::now();
+
     if (!socket.is_open()) {
         logger.error("socket closed", { "NetworkHelpers", "freeSendString" });
     }
@@ -19,12 +22,14 @@ void NetworkHelpers::freeSendString(
     // Note: keep payload alive
     auto payload_ptr = std::make_shared<std::string>(buffer.str());
     asio::async_write(socket, asio::buffer(*payload_ptr, payload_ptr->size()),
-        [payload_ptr, &logger, &socket](auto const& error, auto size) {
+        [payload_ptr, &logger, &socket, start](auto const& error, auto size) {
+            auto const duration_of_send = jt::getDurationInSecondsSince(start);
             if (error) {
                 logger.error(error.message(), { "network", "freeSendString" });
                 socket.close();
             } else {
-                logger.debug("message sent with size: " + std::to_string(size),
+                logger.debug("message sent with size: " + std::to_string(size) + ", took "
+                        + std::to_string(duration_of_send) + "s",
                     { "network", "freeSendString" });
             }
         });

diff --git a/impl/game_server_lib/server_network_connection.cpp b/impl/game_server_lib/server_network_connection.cpp
@@ -134,9 +134,8 @@ void ServerNetworkConnection::handleMessage(
 
 void ServerNetworkConnection::sendMessageToAll(const Message& m)
 {
-
     nlohmann::json const j = m;
-    auto const str = j.dump();
+    auto const str = m_compressor.compress(j.dump());
 
     for (auto& s : m_sockets) {
         if (!s || !s->is_open()) {
@@ -145,7 +144,7 @@ void ServerNetworkConnection::sendMessageToAll(const Message& m)
             return;
         }
 
-        sendStringTo(m_compressor.compress(str), *s);
+        sendStringTo(str, *s);
     }
 }