Use new symbol-overload(_, _) attribute
#984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
force-pushed
the
symbol-overload
branch
from
3a085d4
to
be48961
Compare
4 tasks
Baltoli
force-pushed
the
symbol-overload
branch
from
be48961
to
8e78cca
Compare
Scott-Guest
approved these changes
Feb 16, 2024
rv-jenkins
pushed a commit
to runtimeverification/k
that referenced
this pull request
Feb 20, 2024
The backends have now all been changed to accept the new `symbol-overload` KORE attribute (runtimeverification/llvm-backend#984, runtimeverification/haskell-backend#3723) and so we can safely stop the frontend from emitting the old `overload` syntax. Downstream testing on the C semantics (which makes heavy use of overloading) has passed, so I'm confident this change is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following runtimeverification/k#3989, the KORE attribute that encodes "this axiom declares an overload equality over two symbols
XandY" is being gradually renamed fromoverload(_,_)tosymbol-overload(_,_).This PR moves the LLVM backend over to accepting the new attribute rather than the old one; doing so is a simple renaming process on the attribute following #983. The checked-in KORE test files are updated by a simple renaming of the attribute.1
Blocked on: #983Footnotes
See Automate regeneration of test cases #987; it's a pain to regenerate all the KORE at the moment so I've edited the files manually using
sedrather than the actual K frontend. This is fine for this case in the frontend, but in the future if we make more complex changes to the structure of compiled KORE definitions we should implement a more robust way of rebuilding the test suite to pin against a particular frontend version. ↩