Implement Vec and Symbol
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
gtrepta
approved these changes
Jul 22, 2024
|
|
||
| syntax Int ::= encode6bitChar(Int) [function, total, symbol(encode6bitChar)] | ||
| // --------------------------------------------------------------------------------- | ||
| rule encode6bitChar(I) => 1 requires 9 ==Int I // '_' == I |
There was a problem hiding this comment.
Suggested change
| rule encode6bitChar(I) => 1 requires 9 ==Int I // '_' == I | |
| rule encode6bitChar(I) => 1 requires 95 ==Int I // '_' == I |
Is this a bug? The ASCII code for '_' is 95, though it looks like your integration test is exercising this character.
There was a problem hiding this comment.
You are right. This is a bug. The Rust framework handles the encoding of small symbols on Wasm side without calling the host function. That's why the integration test couldn't catch it.
There was a problem hiding this comment.
Added a hand-written wasm test for small symbols.
Co-authored-by: gtrepta <[email protected]>
Co-authored-by: gtrepta <[email protected]>
Open
asavienko
added a commit
that referenced
this pull request
Sep 4, 2024
add analytics and fix types configs
asavienko
added a commit
that referenced
this pull request
Sep 4, 2024
* Add GitHub workflow for SSL renewal This commit adds a new GitHub Actions workflow for renewing SSL certification periodically. The workflow will operate on user-defined environments, reducing manual effort and ensuring the SSL maintains its validity. The process involves the usage of the acme.sh script, running on self-hosted, Linux, flyweight runners. * fix: Replaced zerossl with letsencrypt --------- Co-authored-by: Yiyi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented host functions:
vec_new_from_linear_memory:v gvec_unpack_to_linear_memory:v hsymbol_new_from_linear_memory:b j