support write MergedEdge during proof #4689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…] directly, because these nodes are already deleted.
Stevengre
force-pushed
the
zjh/merged-edge-support
branch
from
3eb8bbc
to
bf59d17
Compare
tothtamas28
approved these changes
Nov 22, 2024
| @@ -264,18 +264,36 @@ class MergedEdge(EdgeLike): | |||
| edges: tuple[KCFG.Edge, ...] | |||
|
|
|||
| def to_dict(self) -> dict[str, Any]: | |||
|
|
|||
| def _merged_edge_to_dict(edge: KCFG.Edge) -> dict[str, Any]: | |||
There was a problem hiding this comment.
Suggested change
| def _merged_edge_to_dict(edge: KCFG.Edge) -> dict[str, Any]: | |
| def merged_edge_to_dict(edge: KCFG.Edge) -> dict[str, Any]: |
(The functions is only visible from to_dict anyways.)
| } | ||
|
|
||
| @staticmethod | ||
| def from_dict(dct: dict[str, Any], nodes: Mapping[int, KCFG.Node]) -> KCFG.Successor: | ||
|
|
||
| def _merged_edge_from_dict(dct: dict[str, Any]) -> KCFG.Edge: |
There was a problem hiding this comment.
Suggested change
| def _merged_edge_from_dict(dct: dict[str, Any]) -> KCFG.Edge: | |
| def merged_edge_from_dict(dct: dict[str, Any]) -> KCFG.Edge: |
Comment on lines
+116
to
+117
| def _make_edge_dicts(*edges: Iterable) -> list[dict[str, Any]]: | ||
| def _make_edge_dict(i: int, j: int, depth: int = 1, rules: tuple[str, ...] = ()) -> dict[str, Any]: |
There was a problem hiding this comment.
These two functions can be on the same level.
There was a problem hiding this comment.
Suggested change
| def _make_edge_dicts(*edges: Iterable) -> list[dict[str, Any]]: | |
| def _make_edge_dict(i: int, j: int, depth: int = 1, rules: tuple[str, ...] = ()) -> dict[str, Any]: | |
| def make_edge_dicts(*edges: Iterable) -> list[dict[str, Any]]: | |
| def make_edge_dict(i: int, j: int, depth: int = 1, rules: tuple[str, ...] = ()) -> dict[str, Any]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_dict&from_dictmethod forMergedEdgeto_dict_no_nodesmethod to include merged edges.