Hotfix sortk equality issue #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several errors were reported on slack which involve an erroneous injection
inj{SortK, SortKItem}(_).The reason was within the internalisation of
\equalsby booster:equals(A:SortK, B:SortK)was internalised toinj{SortK,SortKItem}(A) ~> .K ==K inj{SortK,SortKItem}(B) ~> .Kinstead of simplyA ==K B.In the investigated case, the problem surfaced when a fallback returned
#Not (#Equals (_:SortK, _: SortK)), which then caused a failure when re-internalising the result to do further execution steps. The added integration tests do not fully reproduce this crash but cause ill-sorted output which will be detected if the error is reintroduced.