EIP-4895: Beacon chain push withdrawals as operations #2559
+255
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing withdrawal operations as specified in EIP-4895.
<withdrawals>
cell map subconfiguration to the<network>
that is used to keep track of withdrawals.Similar to how
<messages>
is implemented,<withdrawals>
has two additional Lists:<withdrawalsPending>
to keep track of the withdrawals that need to be applied.<withdrawalsOrder>
to preserve the order of the withdrawals during thecheck
rules after the execution has finished.EthereumCommands
productions:load "withdraw"
that handles the rlp decoding of the withdrawals array. For each item, the following two productions will be applied:mkWD
- that creates a new<withdrawal>
cell map item.loadWithdraw
- that initialises the newly created<withdrawal>
with values that are provided from the rlp payload.newWithdrawalID
- function that is used to generate a new index**..k
specs**
newWithdrawalID
shouldn't be necesary, as according to the specs:So the provided withdrawal
index
should be enough to keep track of the withdrawals.However, the conformance tests have multiple withdrawals with the
0
index and0
amount (example).