Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add More PassedEnvs for ECR CredHelper #1132

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat: Add More PassedEnvs for ECR CredHelper #1132

merged 2 commits into from
Oct 8, 2024

Conversation

chews93319
Copy link
Contributor

@chews93319 chews93319 commented Oct 7, 2024 •
edited
Loading

Issue #, if available: #868

Description of changes:

Testing done:

  • Local Unit Testing

  • Observing Draft Pull Request Runners for MacOS and WindowsOS

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chews93319 chews93319 changed the title Create Unit Test Helper for PassedEnvs feat: Add More PassedEnvs for ECR CredHelper Oct 7, 2024
@Shubhranshu153
Copy link
Contributor

Env Variable Added:

"SOURCE_DATE_EPOCH",
"AWS_ECR_DISABLE_CACHE"
"AWS_ECR_CACHE_DIR"
"AWS_ECR_IGNORE_CREDS_STORAGE"

@Shubhranshu153 Shubhranshu153 marked this pull request as ready for review October 8, 2024 03:04
@Shubhranshu153 Shubhranshu153 merged commit 0cb6a55 into runfinch:main Oct 8, 2024
29 of 30 checks passed
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Merged
@chews93319 chews93319 deleted the add_PassedEnvs branch October 8, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubhranshu153 Shubhranshu153 Shubhranshu153 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chews93319 @Shubhranshu153