Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow finch commands to run using default config #1109

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

pendo324
Copy link
Member

Issue #, if available:

Description of changes:

  • Makes it so config requirements are not as strict. This allows basic commands, like finch help and finch version to work on Linux, even when not running as root.
  • Also added a warning message when the running user does not have permission to read the config file.

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

swagatbora90
swagatbora90 previously approved these changes Sep 23, 2024
cmd/finch/main_native.go Outdated Show resolved Hide resolved
Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 merged commit 4b57a00 into runfinch:main Sep 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants