Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec-jingle #6984

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update spec-jingle #6984

wants to merge 2 commits into from

Conversation

Servilabs
Copy link
Contributor

update spec jingle to new version, which adds 8 new sounds and a new threshold section for values that only play when the spec reaches that exact value.

@runelite-github-app
Copy link

runelite-github-app bot commented Nov 16, 2024

@tylerwgrass
Copy link
Member

How is someone supposed to know how many sounds there are, what they are, and how to use them?
I don't think someone reading the config is going to understand how to use this.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 16, 2024
Added instruction section
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Nov 17, 2024
@Servilabs
Copy link
Contributor Author

Servilabs commented Nov 17, 2024

Thank you, noted, I have added an instruction section to the config panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants