hotfix:natural speech windows-1252 process stream crash #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UTF-8 IO stream for piper, prevent crash, correctly speak ä accents - remove rich-text-modifier tags from ChatMessages - expand alphanumeric detection to accept diacritics alphabet
|
FWIW, RuneLite does not launch with |
|
This might have been a windows update changing something. I had to run |
(we call them "system" internally)
additional change
|
Nightfirecat
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuneLite JVM launches with
-Dfile.encoding=windows-1252We're unsure when/if this change occurred, but Natural Speech now crashes piper text-to-speech engine when writing to standard stream with
windows-1252encoding. Natural Speech no longer works!The changes in this PR are a couple lines, but will immediately restore Natural Speech functionality.
changelist