Create blert v0.2.0 #6039
Create blert v0.2.0 #6039
Conversation
|
Includes non-plugin changes New plugin |
|
This is a pretty large and complex project, so I'd be happy to discuss it in more detail as it is reviewed. |
|
This should be ready to review now. Happy to chat about anything, and please reach out before merging. |
|
The chances this gets reviewed in a timely manor is very low based on the number of dependencies added |
|
No worries, I don't expect a quick review. Was just pointing out that I don't intend to make any further commits. |
| thirdParty("com.google.gradle:osdetector-gradle-plugin:1.7.3") { | ||
| because "blert" | ||
| } | ||
| thirdParty("kr.motd.maven:os-maven-plugin:1.7.1") { |
There was a problem hiding this comment.
What is this used for? Both your plugin and the plugin hub are gradle projects, not maven projects.
There was a problem hiding this comment.
I tried looking into it but couldn't find exactly where this is pulled in -- I assume it's a transitive of one of the protobuf libraries.
There was a problem hiding this comment.
Oh, I was looking the in wrong place. It is indeed coming from protobuf:
+--- com.google.protobuf:protobuf-gradle-plugin:0.9.4
| \--- com.google.gradle:osdetector-gradle-plugin:1.7.3
| \--- kr.motd.maven:os-maven-plugin:1.7.1
| \--- com.google.code.findbugs:jsr305:3.0.2
|
This would make the build non-reproduceable, please don't include it. |
Removed the remote check, it wasn't actually being used. |
Blert is a PvM tracking and data analysis system hosted at https://blert.io.
This plugin collects data about players' raids and transmits it to the Blert servers to be processed and visualized.