Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for bytes or buffer as input #259

Merged
merged 3 commits into from
Jun 29, 2024
Merged

allow for bytes or buffer as input #259

merged 3 commits into from
Jun 29, 2024

Conversation

sourabhdesai
Copy link
Contributor

allows for clients to pass in the file as bytes or a buffer of bytes. Added tests to cover both bytes and buffer input cases.

hexapode
hexapode approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@hexapode hexapode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you also update the Readme to explain that we handle byte arrays

@sourabhdesai sourabhdesai merged commit 8b96176 into main Jun 29, 2024
8 checks passed
@sourabhdesai sourabhdesai deleted the sour/bytes_input branch June 29, 2024 06:31
@hiteshaylani
Copy link

Please generate a new release so we can use this feature. Installing current version 0.4.4 doesn't include these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexapode hexapode hexapode approved these changes

@logan-markewich logan-markewich Awaiting requested review from logan-markewich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sourabhdesai @hiteshaylani @hexapode