avm2: Allow null ratios is Graphics gradient APIs #18699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
added
T-fix
Lord-McSweeney
approved these changes
Nov 21, 2024
|
Thanks, sorry for breaking this :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18384
Fixes #18452
Fixes #18613
Fixes #18615
Fixes #18627
Fixes #18675
Note: of these I have only tested #18627 .
I didn't unify the code in AVM1 and gradient-related filters; these have their own behaviors that may or may not be correct in edge case scenarios, but at least they don't panic :)
The test was created manually by screenshotting FP, I can't explain why the tolerance=5 is needed; the automated comparison picture didn't help :c