web: Implement URL rewrite rules #18252
Open
+326
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-web
kjarosh
force-pushed
the
url-rewrite
branch
3 times, most recently
from
f96f416
to
4389bd1
Compare
|
Love to see it! Just one thing - can we say more explicitly whether this rewrites URLs in urlrequests, when navigating to a URL, or both? (I assume both, since that would be the most useful.) |
|
Yes, it will rewrite URLs in both network requests and links. Added that to the doc. I originally needed URL rewrite for links only, but I figured that there must be content that needs to have all URLs rewritten in order to work. |
adrian17
approved these changes
Oct 26, 2024
| cl.click(); | ||
| } | ||
| }, | ||
| await player.shadow$$(".modal:not(.hidden)"), |
There was a problem hiding this comment.
WebdriverIO v9 automatically pierces the shadow DOM, so hopefully this .shadow$$ is not needed anymore: https://webdriver.io/docs/api/element/shadow$/
These rules are configurable and they allow rewriting URLs used in SWFs.
The main rationale behind them is to rewrite obsolete links to
working ones in order to preserve old content.
In order to add a rewrite rule, add a `urlRewriteRules` config option
which is an array of rewrite rules. Each rule consists of a matcher
(either a string or a regex), and a replacement, e.g.:
window.RufflePlayer.config = {
"urlRewriteRules": [
// Rewrites to a relative URL
[/^https?:\/\/example.com\/(.*)\.swf$/, "$1.swf"],
// Rewrites to an absolute URL
[/^(.*)\.test\.swf$/, "$1.swf"],
// Rewrites using a string (exact match, not a regex)
["http://old.example.com/site.html", "http://new.example.com/other_site.html"],
],
};
Useful on Chromium-based browsers, where the modal is always displayed at the beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules are configurable and they allow rewriting URLs used in SWFs. The main rationale behind them is to rewrite obsolete links to working ones in order to preserve old content.
In order to add a rewrite rule, add a
urlRewriteRulesconfig option which is an array of rewrite rules. Each rule consists of a matcher (either a string or a regex), and a replacement, e.g.:Related to #1486.