ci: Fix edge ci with updates

[danielhjacobs]

Supersedes #17347 and #17255.

Requesting review from @torokati44 as the one who always does the manual upgrades. See also webdriverio-community/node-edgedriver#365 (comment).

[danielhjacobs]

This was the result of npm remove wdio-chromedriver-service wdio-edgedriver-service wdio-geckodriver-service, a direct deletion of this:

    "optionalDependencies": {
        "chromedriver": "^127.0.1"
    },

Followed by npm install --save-dev chromedriver edgedriver geckodriver and npm install webdriverio

[christian-bromann]

Followed by npm install --save-dev chromedriver edgedriver geckodriver

These are already dependency of @wdio/utils and don't need to be your projects dependencies 😉

[torokati44]

Hmmm...

Error: Error: Failed to initilialise launcher service unknown: Error: Couldn't find plugin "chromedriver" service, neither as wdio scoped package "@wdio/chromedriver-service" nor as community package "wdio-chromedriver-service". Please make sure you have it installed!

Also, look at the typo there, @christian-bromann: 😅 initilialise

[danielhjacobs]

Tried just npm remove wdio-chromedriver-service wdio-edgedriver-service wdio-geckodriver-service and npm install webdriverio without any manual changes to the package files.

[danielhjacobs]

These are already dependency of @wdio/utils and don't need to be your projects dependencies 😉

Yeah, this doesn't seem to be the case, as @torokati44 noted.

[danielhjacobs]

Yeah, this just isn't working @christian-bromann: https://github.com/ruffle-rs/ruffle/actions/runs/10254879764/job/28370602740?pr=17378.

[christian-bromann]

You probably still have the services defined in your wdio.conf.ts/js file, you will have to remove the references there too, otherwise WebdriverIO will try to import them.

[torokati44]

You probably still have the services defined in your wdio.conf.ts/js file, you will have to remove the references there too, ...

Right...: https://github.com/ruffle-rs/ruffle/blob/a00d0e94992084b3b99dba9958391e9e78c2ee8e/web/packages/selfhosted/wdio.conf.ts#L19-62

[christian-bromann]

Please update your package-lock.json and ensure your edgedriver dependency is on v5.6.1

[torokati44]

Thanks for popping in to help, @christian-bromann, this worked!
Are you okay with merging this as is, and closing the two superseded PRs, @danielhjacobs?

[torokati44]

Thank you for really getting to the bottom of this!