Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Run Web tests on Ubuntu 24.04 #17341

Merged
merged 1 commit into from
Sep 24, 2024
Merged

ci: Run Web tests on Ubuntu 24.04 #17341

merged 1 commit into from
Sep 24, 2024

Conversation

torokati44
Copy link
Member

Split out of #16352 due to problems with Edge WebDriver discussed therein.

@torokati44 torokati44 mentioned this pull request Aug 2, 2024
Closed
13 tasks
@torokati44 torokati44 force-pushed the ci-web-ubuntu-24.04 branch 4 times, most recently from 9f89a01 to 820a34f Compare August 6, 2024 13:56
@danielhjacobs
Copy link
Contributor

Strange that the runner-images people consider actions/runner-images#10374 a feature request instead of a bug report. You'd think they'd want parity with Ubuntu 22 for anything that wasn't an intentional removal and I would find it strange if removing Microsoft Edge and Mozilla Firefox was intentional.

@danielhjacobs
Copy link
Contributor

Nope, seems it was stated as intentional:

actions/runner-images#9848

Tool Name Ubuntu 22.04 Ubuntu 24.04 Notes
Microsoft Edge latest available - Removed from the Ubuntu 24.04 image due to maintenance reasons.
Microsoft Edge WebDriver latest available - Removed from the Ubuntu 24.04 image due to maintenance reasons.
Mozilla Firefox latest available - Removed from the Ubuntu 24.04 image due to maintenance reasons.
Mozilla Geckodriver latest available - Removed from the Ubuntu 24.04 image due to maintenance reasons.

We may need to add these installations to CI ourselves.

@danielhjacobs
Copy link
Contributor

Actually, they do seem to plan to add those back: actions/runner-images#9848 (comment)

@torokati44 torokati44 force-pushed the ci-web-ubuntu-24.04 branch 2 times, most recently from 20be9c5 to bc78588 Compare August 14, 2024 00:07
@torokati44
Copy link
Member Author

Oooh, this will hopefully work with the next image release, probably coming out in a few days:

@torokati44 torokati44 added A-tests Area: Tests & Test Framework T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Sep 16, 2024
@torokati44
Copy link
Member Author

Getting closer: actions/runner-images#10626

@torokati44 torokati44 force-pushed the ci-web-ubuntu-24.04 branch 3 times, most recently from 1328718 to b58e6b7 Compare September 17, 2024 12:11
@danielhjacobs
Copy link
Contributor

Rollout status for the image with this software is "Deploying", so this may intermittently succeed or fail until the rollout is finished: https://github.com/actions/runner-images?tab=readme-ov-file#available-images

@torokati44
Copy link
Member Author

The status of the runner image that makes this work has just switched to "Deployed", so this should be good to go now.

@torokati44 torokati44 marked this pull request as ready for review September 19, 2024 09:25
@torokati44 torokati44 force-pushed the ci-web-ubuntu-24.04 branch 2 times, most recently from 5603647 to c6e7d5d Compare September 19, 2024 21:51
@torokati44
Copy link
Member Author

And now it's out of beta even!
actions/runner-images#10653

@torokati44 torokati44 force-pushed the ci-web-ubuntu-24.04 branch 2 times, most recently from b6892cc to c2b8600 Compare September 21, 2024 17:28
@Dinnerbone Dinnerbone enabled auto-merge (rebase) September 24, 2024 17:49
@Dinnerbone Dinnerbone merged commit 5711c18 into ruffle-rs:master Sep 24, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhjacobs danielhjacobs danielhjacobs approved these changes

Assignees
No one assigned
Labels
A-tests Area: Tests & Test Framework T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torokati44 @danielhjacobs @Dinnerbone