Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/prml 1011 pynative model feedback #510

Merged
merged 12 commits into from
Nov 15, 2024
Merged

Feature/prml 1011 pynative model feedback #510

merged 12 commits into from
Nov 15, 2024

Conversation

joker2411
Copy link
Collaborator

Description of the change

Ticket Link.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@joker2411 joker2411 merged commit 7d91675 into main Nov 15, 2024
15 checks passed
@joker2411 joker2411 deleted the feature/prml-1011-pynative-model-feedback branch November 15, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpatchigolla dpatchigolla dpatchigolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joker2411 @dpatchigolla