fix: standard functions

[koladilip]

What are the changes introduced in this PR?

when standard function is using another one then it won't work in some cases as dependent function will be part of source code. This is fixed by using nested function.

What is the related Linear task?

Resolves INT-2160

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

---

Developer checklist

• My code follows the style guidelines of this project

• No breaking changes are being introduced.

• All related docs linked with the PR?

• All changes manually tested?

• Any documentation changes needed with this change?

• Is the PR limited to 10 file changes?

• Is the PR limited to one linear task?

• Are relevant unit and component test-cases added?

Reviewer checklist

• Is the type of change in the PR title appropriate as per the changes?

• Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

• Refactor

  • Improved code readability and reusability for standard functions.

• Tests

  • Added new test scenarios to validate functions like avg(), sum(), min(), max(), etc.

• Chores

  • Simplified logic in the getTemplatePath function for easier maintenance.

[coderabbitai]

Walkthrough

The recent updates enhance code readability and reusability by introducing helper functions to streamline standard mathematical operations. The sum and avg functions in src/operators.ts now use these new helpers with configuration parameters. Additionally, template data scenarios for common array operations were added, and the logic in a utility function was simplified to reduce redundancy.

Changes

Files	Change Summary
src/operators.ts	Refactored sum and avg functions to use helper functions getSumFn and getAvgFn for better readability and reusability.
test/scenarios/standard_functions/data.ts	Added template scenarios for array operations, including functions like avg(), first(), index(), last(), length(), min(), max(), stddev(), and sum().
test/types.ts	Simplified logic in getTemplatePath function by condensing multiple conditional returns into a single expression.

Sequence Diagram(s)

---

Poem

🐇 In the forest of code, changes bloom bright,
Refactored functions take to flight,
With templates prepared, and paths set right,
Operations dance with newfound might.
Averaging sums, templates galore,
Our code now shines, more polished than before. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	100%	4578/4578
🟢	Branches	100%	1221/1221
🟢	Functions	100%	344/344
🟢	Lines	100%	4578/4578

Test suite run success

178 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 0a14bda

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97d95e8) to head (0a14bda).
Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         4565      4578   +13     
  Branches      1082      1076    -6     
=========================================
+ Hits          4565      4578   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

src/operators.ts (1)

Line range hint 122-169: The introduction of getSumFn and getAvgFn enhances modularity and readability. Consider adding a check for division by zero in the avg function to prevent runtime errors.

-    return sum(arr) / arr.length;
+    return arr.length > 0 ? sum(arr) / arr.length : throw new Error('Division by zero');

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a47d40c and 0a14bda.

Files selected for processing (3)

• src/operators.ts (3 hunks)
• test/scenarios/standard_functions/data.ts (1 hunks)
• test/types.ts (1 hunks)

Additional comments not posted (2)

test/types.ts (1)

17-17: Simplified fallback logic in getTemplatePath enhances readability and maintainability.

test/scenarios/standard_functions/data.ts (1)

15-63: The added scenarios comprehensively cover various array operations, ensuring robust testing of standard functions.