Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json remove type module #93

Merged
merged 2 commits into from
Jun 14, 2024
Merged

fix: package.json remove type module #93

merged 2 commits into from
Jun 14, 2024

Conversation

koladilip
Copy link
Collaborator

@koladilip koladilip commented Jun 14, 2024

What are the changes introduced in this PR?

This is causing issue to import this in transformer

What is the related Linear task?

Resolves INT-2160

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

  • Chores
    • Updated .eslintignore to include all vite.config.*ts files.
    • Changed commitlint.config.js to use module.exports instead of ES module export.
    • Removed the "type": "module" entry from package.json.

@koladilip koladilip requested a review from a team as a code owner June 14, 2024 04:18
Copy link

coderabbitai bot commented Jun 14, 2024

Walkthrough

These updates focus on enhancing configuration flexibility and compatibility within the project's tooling. The eslintignore modification broadens ignored file patterns to include any TypeScript files matching vite.config.*ts. The commitlint.config.js switch to CommonJS syntax and the removal of the "type": "module" entry in package.json promote consistency and address compatibility issues across modules.

Changes

Files Change Summaries
.eslintignore Changed to include files matching vite.config.*ts
commitlint.config.js Switched from ES module to CommonJS syntax
package.json Removed the "type": "module" entry

Poem

🍃 In the code where configs merge,
TypeScript files now in a surge.
No more modules quite misfit,
CommonJS has seized the writ.
ESLint snoozes, less to track,
Commitlint's path is right on track.
🌟 The project's path is now more clear,
A streamlined flow, let's all cheer! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Jun 14, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 4568/4568
🟢 Branches 100% 1219/1219
🟢 Functions 100% 342/342
🟢 Lines 100% 4568/4568

Test suite run success

168 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 81aad02

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97d95e8) to head (2eb2eb1).
Report is 15 commits behind head on main.

Current head 2eb2eb1 differs from pull request most recent head 81aad02

Please upload reports for the commit 81aad02 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #93   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         4565      4568    +3     
  Branches      1082      1074    -8     
=========================================
+ Hits          4565      4568    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@koladilip koladilip merged commit 8849705 into main Jun 14, 2024
8 checks passed
@koladilip koladilip deleted the fix.package.json branch June 14, 2024 04:20
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4fe306d and 81aad02.

Files selected for processing (3)
  • .eslintignore (1 hunks)
  • commitlint.config.js (1 hunks)
  • package.json (1 hunks)
Files skipped from review due to trivial changes (3)
  • .eslintignore
  • commitlint.config.js
  • package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants