Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(INT-667): add support for short key value in object expr #40

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

koladilip
Copy link
Collaborator

@koladilip koladilip commented Sep 19, 2023

Description of the change

Add support for following syntax:

let a = 1;
let b = 2;
{
a,
b
}

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@koladilip koladilip requested a review from utsabc September 19, 2023 11:59
@koladilip koladilip requested review from saikumarrs and a team as code owners September 19, 2023 11:59
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 3105/3105
🟢 Branches 100% 829/829
🟢 Functions 100% 246/246
🟢 Lines 100% 3105/3105

Test suite run success

73 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 6d31f2c

@koladilip koladilip requested a review from a team as a code owner September 19, 2023 12:04
@koladilip koladilip changed the title feat: add support for short key value in object expr feat(INT-667): add support for short key value in object expr Sep 20, 2023
@koladilip koladilip merged commit 0f1e5ea into main Sep 20, 2023
4 of 5 checks passed
@koladilip koladilip deleted the feat.short-key-value-object-expr branch September 20, 2023 05:16
@koladilip koladilip restored the feat.short-key-value-object-expr branch September 20, 2023 05:16
@koladilip koladilip deleted the feat.short-key-value-object-expr branch September 20, 2023 05:16
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants