feat: add support for or mappings #109
Conversation
WalkthroughThe recent changes introduced a new function Changes
Sequence DiagramssequenceDiagram
participant MainProcess as Main Process
participant Converter as converter.ts
participant Handler as handleLastOutputPart
MainProcess ->> Converter: Invoke processFlatMappingPart
Converter ->> Handler: Call handleLastOutputPart
Handler -->> Converter: Return updated output properties
Converter -->> MainProcess: Return processed output
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success201 tests passing in 6 suites. Report generated by 🧪jest coverage report action from 3d09940 |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
===========================================
- Coverage 100.00% 91.68% -8.32%
===========================================
Files 14 18 +4
Lines 4565 4836 +271
Branches 1082 1058 -24
===========================================
- Hits 4565 4434 -131
- Misses 0 395 +395
- Partials 0 7 +7 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/utils/converter.ts (3 hunks)
- test/scenarios/mappings/data.ts (1 hunks)
- test/scenarios/mappings/or_mappings.json (1 hunks)
Files skipped from review due to trivial changes (1)
- test/scenarios/mappings/or_mappings.json
Additional context used
Learnings (1)
src/utils/converter.ts (1)
User: koladilip PR: rudderlabs/rudder-json-template-engine#97 File: src/utils/converter.ts:169-184 Timestamp: 2024-06-15T03:36:36.164Z Learning: Validations for `flatMapping` and `currentOutputPropAST` are performed before they are passed to the `handleNextParts` function in `src/utils/converter.ts`.
GitHub Check: codecov/patch
src/utils/converter.ts
[warning] 272-277: src/utils/converter.ts#L272-L277
Added lines #L272 - L277 were not covered by tests
GitHub Check: Coverage annotations (🧪 jest-coverage-report-action)
src/utils/converter.ts
[warning] 272-272: 🧾 Statement is not covered
Warning! Not covered statement
[warning] 273-273: 🧾 Statement is not covered
Warning! Not covered statement
[warning] 274-274: 🧾 Statement is not covered
Warning! Not covered statement
[warning] 275-275: 🧾 Statement is not covered
Warning! Not covered statement
[warning] 276-276: 🧾 Statement is not covered
Warning! Not covered statement
[warning] 277-277: 🧾 Statement is not covered
Warning! Not covered statement
[warning] 271-277: 🌿 Branch is not covered
Warning! Not covered branch
Additional comments not posted (1)
test/scenarios/mappings/data.ts (1)
303-355: Review of the new 'or' mappings scenariosThe addition of these scenarios aligns with the PR's objective to support multiple input mappings for the same output. The scenarios are well-structured and provide varied test cases to ensure the new functionality is covered. It's important to ensure that these scenarios are included in the test execution plan to validate the new feature comprehensively.
What are the changes introduced in this PR?
Now we can have multiple input mappings for same output mappings
What is the related Linear task?
Resolves INT-2240
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit
New Features
Tests