fix: sonar issues

rudderlabs · Oct 16, 2024 · f8cff74 · f8cff74
1 parent bfc8caa
commit f8cff74
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/engine.ts b/src/engine.ts
@@ -70,7 +70,7 @@ export class JsonTemplateEngine {
     if (
       /^'.*'$/.test(input) ||
       /^".*"$/.test(input) ||
-      /^[a-zA-Z0-9_]*$/.test(input) ||
+      /^\w+$/.test(input) ||
       input.includes('.')
     ) {
       return `$.${input}`;

diff --git a/src/parser.ts b/src/parser.ts
@@ -57,11 +57,11 @@ type PathTypeResult = {
 };
 
 export class JsonTemplateParser {
-  private lexer: JsonTemplateLexer;
+  private readonly lexer: JsonTemplateLexer;
 
-  private options?: EngineOptions;
+  private readonly options?: EngineOptions;
 
-  private pathTypesStack: PathTypeResult[] = [];
+  private readonly pathTypesStack: PathTypeResult[] = [];
 
   // indicates currently how many loops being parsed
   private loopCount = 0;

diff --git a/src/reverse_translator.ts b/src/reverse_translator.ts
@@ -38,7 +38,7 @@ import { BINDINGS_PARAM_KEY, DATA_PARAM_KEY, EMPTY_EXPR, INDENTATION_SPACES } fr
 import { escapeStr } from './utils';
 
 export class JsonTemplateReverseTranslator {
-  private options?: EngineOptions;
+  private readonly options?: EngineOptions;
 
   private level = 0;