fix: indentation for objects (#101)

* fix: array and object mappings * fix: indentiation for objects * fix: indentation for objects * fix: indentation for objects * fix: indentation for objects
rudderlabs · Jun 18, 2024 · b7ca7be · b7ca7be
1 parent 4fe6873
commit b7ca7be
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/src/constants.ts b/src/constants.ts
@@ -6,4 +6,5 @@ export const BINDINGS_PARAM_KEY = '___b';
 export const BINDINGS_CONTEXT_KEY = '___b.context.';
 export const RESULT_KEY = '___r';
 export const FUNCTION_RESULT_KEY = '___f';
+export const INDENTATION_SPACES = 4;
 export const EMPTY_EXPR = { type: SyntaxType.EMPTY };
diff --git a/src/reverse_translator.ts b/src/reverse_translator.ts
@@ -33,7 +33,7 @@ import {
   UnaryExpression,
 } from './types';
 import { translateLiteral } from './utils/translator';
-import { BINDINGS_PARAM_KEY, DATA_PARAM_KEY, EMPTY_EXPR } from './constants';
+import { BINDINGS_PARAM_KEY, DATA_PARAM_KEY, EMPTY_EXPR, INDENTATION_SPACES } from './constants';
 import { escapeStr } from './utils';
 
 export class JsonTemplateReverseTranslator {
@@ -215,8 +215,8 @@ export class JsonTemplateReverseTranslator {
     return `throw ${this.translateExpression(expr.value)}`;
   }
 
-  translateExpressions(exprs: Expression[], sep: string): string {
-    return exprs.map((expr) => this.translateExpression(expr)).join(sep);
+  translateExpressions(exprs: Expression[], sep: string, prefix: string = ''): string {
+    return exprs.map((expr) => `${prefix}${this.translateExpression(expr)}`).join(sep);
   }
 
   translateLambdaFunctionExpression(expr: FunctionExpression): string {
@@ -429,16 +429,17 @@ export class JsonTemplateReverseTranslator {
     return `...${this.translateExpression(expr.value)}`;
   }
 
+  getIndentation(): string {
+    return ' '.repeat(this.level * INDENTATION_SPACES);
+  }
+
   translateObjectExpression(expr: ObjectExpression): string {
     const code: string[] = [];
-    const prevIndentation = '  '.repeat(this.level);
-    code.push('{\n');
+    code.push('{');
     this.level++;
-    const currIndentation = '  '.repeat(this.level);
-    code.push(currIndentation);
-    code.push(this.translateExpressions(expr.props, `,\n${currIndentation}`));
+    code.push(this.translateExpressions(expr.props, ',', `\n${this.getIndentation()}`));
     this.level--;
-    code.push(`\n${prevIndentation}}`);
+    code.push(`\n${this.getIndentation()}}`);
     return code.join('');
   }