fix: binding param in new operator syntax (#60)

* fix: tokenize $ as id than punctuator tokenizing $ as punctuator is breaking existing workflow engine * fix: binding param in new operator syntax this fix is to support new $.CustomError("some error") syntax.
rudderlabs · Jun 6, 2024 · a5a998c · a5a998c
1 parent 3e09696
commit a5a998c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -975,7 +975,11 @@ export class JsonTemplateParser {
   private parseIDPath(): string {
     const idParts: string[] = [];
     while (this.lexer.matchID()) {
-      idParts.push(this.lexer.value());
+      let idValue = this.lexer.value();
+      if (idValue === '$') {
+        idValue = BINDINGS_PARAM_KEY;
+      }
+      idParts.push(idValue);
       if (this.lexer.match('.') && this.lexer.matchID(1)) {
         this.lexer.ignoreTokens(1);
       }

diff --git a/src/reverse_translator.ts b/src/reverse_translator.ts
@@ -273,7 +273,7 @@ export class JsonTemplateReverseTranslator {
         code.push(` .${expr.id}`);
       }
     } else if (expr.id) {
-      code.push(expr.id);
+      code.push(expr.id.replace(BINDINGS_PARAM_KEY, '$'));
     }
     code.push('(');
     if (expr.args) {

diff --git a/test/scenarios/bindings/data.ts b/test/scenarios/bindings/data.ts
@@ -1,5 +1,7 @@
 import { Scenario } from '../../types';
 
+class CustomError extends Error {}
+
 export const data: Scenario[] = [
   {
     templatePath: 'async.jt',
@@ -10,6 +12,11 @@ export const data: Scenario[] = [
     input: [1, 2, 3],
     output: [1, 2, 3],
   },
+  {
+    templatePath: 'new_operator.jt',
+    bindings: { CustomError },
+    output: new CustomError('some error'),
+  },
   {
     bindings: {
       a: 10,

diff --git a/test/scenarios/bindings/new_operator.jt b/test/scenarios/bindings/new_operator.jt
@@ -0,0 +1 @@
+new $.CustomError("some error")