feat: google ads new UI #1782
feat: google ads new UI #1782
Conversation
aashishmalik
requested review from
lvrach,
cisse21,
debanjan97,
am6010,
ssbeefeater,
AchuthaSourabhC,
ruchiramoitra,
ItsSudip,
shrouti1507,
sandeepdsvs,
krishna2020 and
1abhishekpandey
as code owners
WalkthroughThe pull request introduces a significant restructuring of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1782 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (4)
src/configurations/destinations/googleads/ui-config.json (4)
251-252: Standardize visibility notes across templatesThere are inconsistent "not visible in the ui" notes in different sections. Consider standardizing how visibility is handled across templates instead of using text notes.
Also applies to: 345-345
15-22: Document the Conversion ID regex patternThe regex pattern allows for template variables, environment variables, and actual conversion IDs, but this flexibility isn't documented in the UI. Consider adding a note explaining the accepted formats:
- Template variables:
{{variable||fallback}}- Environment variables:
env.VARIABLE- Actual conversion IDs:
AW-XXXXXXXX
Line range hint
365-371: Optimize feature flag conditionsThe feature flag conditions appear redundant. When using OR logic, checking for both
value: falseand existence is unnecessary as the existence check will always evaluate to true."featureFlags": [ { "configKey": "AMP_enable-gcm", "value": false - }, - { - "configKey": "AMP_enable-gcm" } ],Also applies to: 385-391, 464-470
292-295: Add documentation for Enhanced ConversionsThe "Allow Enhanced Conversions" setting should include a note about:
- Required user data fields (email, phone, etc.)
- Privacy implications and data handling
- Link to Google's documentation about enhanced conversions
| "name": "Purchase", | ||
| "value": "purchase" | ||
| } |
There was a problem hiding this comment.
Fix inconsistent event name casing
The "purchase" event name uses lowercase while all other event names use PascalCase.
{
"name": "Purchase",
- "value": "purchase"
+ "value": "Purchase"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "name": "Purchase", | |
| "value": "purchase" | |
| } | |
| "name": "Purchase", | |
| "value": "Purchase" | |
| } |
| "label": "Map your RudderStack Events to Facebook Pixel IDs", | ||
| "note": "Input the RudderStack event to map to Facebook's pixel id.", |
There was a problem hiding this comment.
Fix incorrect provider name in legacy conversion mapping
The label mentions "Facebook Pixel IDs" instead of "Google Ads conversion IDs".
- "label": "Map your RudderStack Events to Facebook Pixel IDs",
- "note": "Input the RudderStack event to map to Facebook's pixel id.",
+ "label": "Map your RudderStack Events to Google Ads Conversion IDs",
+ "note": "Input the RudderStack event to map to Google Ads conversion ID.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "label": "Map your RudderStack Events to Facebook Pixel IDs", | |
| "note": "Input the RudderStack event to map to Facebook's pixel id.", | |
| "label": "Map your RudderStack Events to Google Ads Conversion IDs", | |
| "note": "Input the RudderStack event to map to Google Ads conversion ID.", |
|
OLD SS: 
New UI: 
|
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
Resolves INT-XXX
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit
New Features
Conversion IDand consent settings.redirectGroupssection for better event mapping and conversion tracking.Improvements
Conversion ID.