Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File based config persistence #14

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

File based config persistence #14

wants to merge 5 commits into from

Conversation

lokey
Copy link
Collaborator

@lokey lokey commented Jun 10, 2021 •
edited
Loading

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@lokey lokey requested a review from MiteshSharma June 10, 2021 01:14
lokey
lokey commented Sep 17, 2021
View reviewed changes
src/stores/connections.ts Outdated
const store: IConnectionsStore = JSON.parse(connectionsStore);
set(this, store);
console.log(toJS(this.rootStore));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiteshSharma MiteshSharma Awaiting requested review from MiteshSharma

@snarkychef snarkychef Awaiting requested review from snarkychef

@AkhileshK8y AkhileshK8y Awaiting requested review from AkhileshK8y

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lokey