Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings stream response if stream unavailable #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: settings stream response if stream unavailable #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,6 @@ class Settings(FreshdeskStream):
def path(self, **kwargs) -> str:
return "settings/helpdesk"

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
yield response.json()

# Skills api keeps failing with 404 error maybe because this resource is available only for enterprise accounts users.
# Not sure as the documentation is not clear about it. Disabling it for now.
Expand Down