Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update facebook_marketing version to v20.0 and made schema changes #200

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

vinayteki95
Copy link

…es - breaking change

Source Facebook Connector is failing due to deprecated api usage.

During the sync, the following streams did not sync successfully:
ads_insights_country: AirbyteTracedException('
  Message: Call was not successful
  Method:  GET
  Path:    https://graph.facebook.com/v18.0/act_<CLIENT_ACCOUNT_ID>/insights\n  Params:  {}
  Status:  400
  Response:\n    {
      "error": {
        "message": "(#2635) You are calling a deprecated version of the Ads API. Please upgrade to the latest version: v20.0.",\
        "type": "OAuthException",
        "code": 2635,\…

Breaking changes for insights api that we use in v19.0
https://developers.facebook.com/docs/marketing-api/marketing-api-changelog/version19.0/

Required Changes (To deal with breaking changes):

Fields param acceptable enum values have changed.

{
  "error": {
    "message": "(#100) age_targeting, gender_targeting, labels, location, estimated_ad_recall_rate_lower_bound, estimated_ad_recall_rate_upper_bound, estimated_ad_recallers_lower_bound, estimated_ad_recallers_upper_bound are not valid for fields param after V19.0",
    "type": "OAuthException",
    "code": 100,
    "fbtrace_id": "----------------------"
  }
}

We are currently requesting for all fields from the api using the corresponding schema that was defined.
This is the file that holds the schema: airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json

This file has been updated to remove the fields which are no longer available. Using these fields causes a 400 error.

@vinayteki95 vinayteki95 self-assigned this Aug 14, 2024
Copy link

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@vinayteki95 vinayteki95 merged commit 4178f8f into main Aug 14, 2024
0 of 3 checks passed
@vinayteki95 vinayteki95 deleted the fix.etl-357.fb-api-version-deprecated branch August 14, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants