Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include internal error message #189

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: include internal error message #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,5 +224,6 @@ def _find_account(account_id: str) -> AdAccount:
)
raise AirbyteTracedException(
message=message,
internal_message=message,
failure_type=FailureType.config_error,
) from exc
1 change: 1 addition & 0 deletions ...yte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ def get_custom_insights_streams(self, api: API, config: ConnectorConfig) -> List
)
raise AirbyteTracedException(
message=message,
internal_message=message,
krishna2020 marked this conversation as resolved.
Show resolved Hide resolved
failure_type=FailureType.config_error,
)
stream = AdsInsights(
Expand Down
6 changes: 4 additions & 2 deletions ...ctors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,11 @@ def read_records(
for obj in job.get_result():
yield obj.export_all_data()
except FacebookBadObjectError as e:
message = f"API error occurs on Facebook side during job: {job}, wrong (empty) response received with errors: {e} "
f"Please try again later"
raise AirbyteTracedException(
message=f"API error occurs on Facebook side during job: {job}, wrong (empty) response received with errors: {e} "
f"Please try again later",
message=message,
internal_message=message,
failure_type=FailureType.system_error,
) from e

Expand Down
Loading