CMS: probe checking the number and volume of rules per rse, activity and state #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eachristgr
added a commit
to eachristgr/CMSRucio
that referenced
this pull request
Nov 11, 2024
eachristgr
added a commit
to eachristgr/CMSRucio
that referenced
this pull request
Nov 11, 2024
ericvaandering
requested changes
Nov 27, 2024
| # - The information is retried using the following tables in the specified order: rules -> contents -> dids. | ||
| # - For these states volume information can be retrieved from contents and dids table. | ||
| # Although, only rules with container dids are counted. If a rule is created using a did of a different type it will be ignored. | ||
| # - For rules in this state, the information about the destination rse is (only maybe?) available at the rules table (ReplicationRule) under rse_expression. |
There was a problem hiding this comment.
Please break up this and all the other long lines.
There was a problem hiding this comment.
Thanks to @ericvaandering for the feedback.
I’ve reformatted the comments by breaking up the long lines. Please let me know if anything else is needed.
ericvaandering
added a commit
to dmwm/CMSRucio
that referenced
this pull request
Nov 27, 2024
ericvaandering
requested changes
Dec 2, 2024
| # as the DB will need to update this index as well. | ||
| # - For this reason, handling rules of these states is better implemented using HDFS dumps. | ||
|
|
||
| rse = case((models.ReplicationRule.rse_expression.startswith("rse="), func.substr(models.ReplicationRule.rse_expression, 5, func.length(models.ReplicationRule.rse_expression) - 4)), else_=models.ReplicationRule.rse_expression).label("rse") |
There was a problem hiding this comment.
Wrap this too. Here the parenthesis give you an easy way to do it.
|
|
||
| with PrometheusPusher() as manager: | ||
| for rse, activity, state, count, volume in query.all(): | ||
| manager.gauge(name='rule_count_per_rse_activity_state.{rse}.{activity}.{state}', documentation='Number of rules in a given rse, activity and state').labels(rse=rse, activity=activity, state=state).set(count) |
| with PrometheusPusher() as manager: | ||
| for rse, activity, state, count, volume in query.all(): | ||
| # print(rse, activity, state.name, count, volume) | ||
| manager.gauge(name='rule_count_per_rse_activity_state.{rse}.{activity}.{state}', documentation='Number of rules in a given rse, activity and state').labels(rse=rse, activity=activity, state=state.name).set(count) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dmwm/CMSRucio#747
The script acts on rules with the following states:
OKREPLICATINGSTUCKThe script pushes the following metrics by using
PrometheusPusher:rule_count_per_rse_activity_state: The number of rules perrse,activityandstaterule_volume_per_rse_activity_state: The total size (in bytes) of rules perrse,activityandstateTested it on Integration and it works as far as I can see.
More details about the implementation are commented in the script.
FYI @haozturk