Port check_unevaluated_dids to SQLAlchemy 2.0 sytnax #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have an are running a version of this with prometheus changes as well in #132 I notice you and Maggie chose different SQL statements. No thoughts on which is better, but I'd like to use most of her changes. Can we merge the two changes? |
|
Maggie’s PR keeps the SQLAlchemy code with either raw text queries or in the 1.4 syntax. This PR ports them to the 2.0 syntax. I can wait for that one to be merged then rework this one on top of it. |
|
Given that the mentioned PR is being delayed, I believe it would be better for this and #137 to be reviewed. It will reduce Maggie’s future work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And various other small improvements.