Addressing PR comments

common/check_expired_locked_rules

@@ -34,12 +34,14 @@ if __name__ == "__main__":
     status = OK
     session = session.get_session()
 
+    # Select statement used for both metrics
     base_statement = select(
         models.ReplicationRule,
         models.DataIdentifier.name,
         models.DataIdentifier.scope,
         models.ReplicationRule.rse_expression,
     )
+    # Use prometheus pusher to send results to a remote service
     with PrometheusPusher() as manager:
         try:
             statement = base_statement.where(
@@ -48,17 +50,21 @@ if __name__ == "__main__":
                     models.ReplicationRule.expires_at < datetime.now(tz=timezone.utc),
                 )
             )
-            query = session.execute(statement).scalars()
+            query = session.execute(statement).all()
             rule_counts = defaultdict(int)
 
+            # Print rules for nagios monitoring
             print("Locked expired rules")
             for rule_id, scope, name, rse_expression in query:
                 print(rule_id, scope, name, rse_expression)
                 status = CRITICAL
                 rule_counts[rse_expression] += 1
 
+            # Add an empty entry where there is no result so the metric has continuity
             if len(rule_counts.keys()) == 0:
                 rule_counts["All"] = 0
+
+            # Send to Prometheus pusher
             for rse_expression, count in rule_counts.items():
                 (
                     manager.gauge(
@@ -88,7 +94,7 @@ if __name__ == "__main__":
                 )
             )
 
-            query = session.execute(statement).scalars()
+            query = session.execute(statement).all()
             datasets_count = defaultdict(int)
 
             print("Datasets expired with locked rules")