-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the "Background Jobs" section #278
Open
janko
wants to merge
24
commits into
rubytoolbox:main
Choose a base branch
from
janko:update-background-jobs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It hasn't received commit activity for over 4 years, and it doesn't appear to even be a Ruby library (it's all C).
The delayed_job gem is already listed, and it recommends using delayed_job_active_record in the README, so there is no need to list delayed_job_active_record as well. This keeps the list more focused.
amqp is just a RabbitMQ client library, it's not a full-blown background job library. It's also limited to EventMachine, which isn't an active ecosystem anymore ("async" is much better).
girl_friday has been deprecated over sucker_punch for over 4 years now.
It hasn't received a commit for over 4 years. If it's revived, then we can add it back.
It hasn't received a commit in over 8 years.
It hasn't received a commit in over 9 years.
It hasn't received a commit in over 5 years and has open issues.
It hasn't received a commit in over 9 years, and has some open issues.
It hasn't received a commit in 7 years, and has some open pull requests.
It hasn't received a commit in 2 and a half years, and doesn't appear to be active otherwise.
The repo and gem doesn't appear to exist anymore.
We remove extensions of specific backgrounding libraries to keep the list more focused. Otherwise it creates a slippery slope where it's a question why wouldn't we list all extensions for each backgrounding library.
It hasn't received a commit in over 7 years.
It hasn't received a commit in over 7 years.
It hasn't received a commit in over 8 years.
It hasn't received a commit in over 4 years, has only 9 stars, and doesn't even have a README.
It hasn't seen a release for over 9 years.
It hasn't received a commit for over 7 years and has been archived.
It hasn't received a commit in over 6 years.
It hasn't received a commit in over 6 years.
It hasn't received an update in over 4 years, and has some open issues and pull requests.
It only has a 0.0.0 release and the repo is gone.
It hasn't received a commit for over 10 years.
Please discuss in rubytoolbox/rubytoolbox#7 first. We don’t have a convention that unmaintained gem should be cleaned up, unless it is removed from RubyGems. This also applies for the other 3 Pull Requests about “cleaning up”. |
Putting this on hold until we reach some conclusion in rubytoolbox/rubytoolbox#7 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes many outdated gems from the "Background Jobs" section, reducing the number of gems from 40 to 13.
I've verified that it's useful to clean up these unmaintained gems, because RocketJob, a modern library that is actively maintained, was buried underneath a pile of less popular and long unmaintained gems.