Permit acts_as_paranoid to be given on abstract AR classes #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure seems unrelated to the changes in this PR, let me know what you want me to do about it. |
|
My Rails app is using abstract classes with paranoia and running into the issue that this PR solves. Any chance this work can get reviewed and merged into the next release? |
BenMorganIO
reviewed
Mar 10, 2017
| # triggers https://github.com/rails/rails/issues/10658 / | ||
| # https://github.com/rails/rails/issues/23413 | ||
| # if default_scope is specified as a closure instead of a class method | ||
| child = ParanoidChild.first |
There was a problem hiding this comment.
What are you asserting to not happen here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around rails/rails#10658
and rails/rails#23413.