homework 1 #771
Open
homework 1 #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 20, 2018
2018/Serg-Lapata/hw-1/task.rb
Outdated
| width_element = rows.last.max.to_s.length + 1 | ||
| width_last_row = width_element * rows.last.length | ||
|
|
||
| rows.each.with_index do |row, row_number| |
There was a problem hiding this comment.
Inconsistent indentation detected.
2018/Serg-Lapata/hw-1/task.rb
Outdated
|
|
||
| def print_triangle(rows)[] | ||
| width_element = rows.last.max.to_s.length + 1 | ||
| width_last_row = width_element * rows.last.length |
There was a problem hiding this comment.
Inconsistent indentation detected.
2018/Serg-Lapata/hw-1/task.rb
Outdated
| end | ||
|
|
||
| def print_triangle(rows)[] | ||
| width_element = rows.last.max.to_s.length + 1 |
There was a problem hiding this comment.
Inconsistent indentation detected.
2018/Serg-Lapata/hw-1/task.rb
Outdated
| check_integer(int.to_i) | ||
| end | ||
|
|
||
| def print_triangle(rows)[] |
2018/Serg-Lapata/hw-1/task.rb
Outdated
| end | ||
|
|
||
| def check_integer(int) | ||
| int < 1 ? raise('Got invalid number') : int.positive? ? int : raise('Got invalid number') |
There was a problem hiding this comment.
Ternary operators must not be nested. Prefer if or else constructs instead.
Line is too long. [91/80]
houndci-bot
reviewed
Feb 20, 2018
2018/Serg-Lapata/hw-1/task.rb
Outdated
| end | ||
|
|
||
| def check_integer(int) | ||
| int.positive? ? int : raise('Got invalid number') |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indentation.
houndci-bot
reviewed
Feb 20, 2018
2018/Serg-Lapata/hw-1/task.rb
Outdated
| end | ||
|
|
||
| def check_integer(int) | ||
| int.positive? ? int : raise('Got invalid number') |
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
Xanderwot
approved these changes
Mar 11, 2018
| current_value = start_value | ||
| row = [current_value] | ||
| k = 1 | ||
| row_number.times do |
There was a problem hiding this comment.
а почему бы аналог k переменной не передать в блок? Ведь times это может и тогда этот вот k = 1 можно будет убрать
Xanderwot
reviewed
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Фамилия Имя
Сергей Лапата
Email
[email protected]
Номер домашнего задания
1
Ссылка на видео с демо работы
https://www.youtube.com/watch?v=ecIWPzGEbFc