Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw 1 #766

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

hw 1 #766

wants to merge 6 commits into from

Conversation

552687773
Copy link

Фамилия Имя

Дмитрий Шкуратов

Email

[email protected]

Номер домашнего задания

1

Ссылка на видео с демо работы

https://youtu.be/-stl_LHE4-k

Комментарии

nothing

strings.each do |line|
puts line.join.center(strings[-1].join.length)
end
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 23, 3 is not aligned with def at 17, 2.

max = to_pascal.flatten.max.to_s.length
strings = to_pascal.map {|arr| arr.map {|int| int.to_s.center(max + 3)} }
strings.each do |line|
puts line.join.center(strings[-1].join.length)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 0) spaces for indentation.


def print_triangle
max = to_pascal.flatten.max.to_s.length
strings = to_pascal.map {|arr| arr.map {|int| int.to_s.center(max + 3)} }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between { and | missing.
Space missing inside }.

temp << line
end
temp
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 15, 0 is not aligned with def at 7, 2.

(0..row-1).each {|x| line << (line[x] * (row-x) / (x+1)) }
temp << line
end
temp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected.

line = [1]
(0..row-1).each {|x| line << (line[x] * (row-x) / (x+1)) }
temp << line
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 13, 2 is not aligned with @rows.times do |row| at 9, 4.

temp = []
@rows.times do |row|
line = [1]
(0..row-1).each {|x| line << (line[x] * (row-x) / (x+1)) }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surrounding space missing for operator -.
Space between { and | missing.
Surrounding space missing for operator +.

strings.each do |line|
puts line.join.center(strings[-1].join.length)
end
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 24, 0 is not aligned with def at 18, 2.

max = to_pascal.flatten.max.to_s.length
strings = to_pascal.map { |arr| arr.map { |int| int.to_s.center(max + 3)} }
strings.each do |line|
puts line.join.center(strings[-1].join.length)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 0) spaces for indentation.


def print_triangle
max = to_pascal.flatten.max.to_s.length
strings = to_pascal.map { |arr| arr.map { |int| int.to_s.center(max + 3)} }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing inside }.

temp
end

def print_triangle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected.

end
end
temp
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 16, 2 is not aligned with class at 1, 0.

def to_pascal
temp = []
@rows.times do |row|
line = [1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 0) spaces for indentation.

strings = to_pascal.map { |arr| arr.map { |int| int.to_s.center(max + 3)} }
strings.each do |line|
puts line.join.center(strings[-1].join.length)
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 23, 2 is not aligned with strings.each do |line| at 21, 4.

temp << line
end
end
temp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected.

@Xanderwot Xanderwot mentioned this pull request Mar 11, 2018
Copy link
Contributor

@Xanderwot Xanderwot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

подозрение на плагиат

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants