-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hw 1 #766
base: master
Are you sure you want to change the base?
hw 1 #766
Conversation
2018/DmitryShkuratov/1/homework-1.rb
Outdated
strings.each do |line| | ||
puts line.join.center(strings[-1].join.length) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 23, 3 is not aligned with def at 17, 2.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
max = to_pascal.flatten.max.to_s.length | ||
strings = to_pascal.map {|arr| arr.map {|int| int.to_s.center(max + 3)} } | ||
strings.each do |line| | ||
puts line.join.center(strings[-1].join.length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 (not 0) spaces for indentation.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
|
||
def print_triangle | ||
max = to_pascal.flatten.max.to_s.length | ||
strings = to_pascal.map {|arr| arr.map {|int| int.to_s.center(max + 3)} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space between { and | missing.
Space missing inside }.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
temp << line | ||
end | ||
temp | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 15, 0 is not aligned with def at 7, 2.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
(0..row-1).each {|x| line << (line[x] * (row-x) / (x+1)) } | ||
temp << line | ||
end | ||
temp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation detected.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
line = [1] | ||
(0..row-1).each {|x| line << (line[x] * (row-x) / (x+1)) } | ||
temp << line | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 13, 2 is not aligned with @rows.times do |row| at 9, 4.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
temp = [] | ||
@rows.times do |row| | ||
line = [1] | ||
(0..row-1).each {|x| line << (line[x] * (row-x) / (x+1)) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surrounding space missing for operator -.
Space between { and | missing.
Surrounding space missing for operator +.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
strings.each do |line| | ||
puts line.join.center(strings[-1].join.length) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 24, 0 is not aligned with def at 18, 2.
max = to_pascal.flatten.max.to_s.length | ||
strings = to_pascal.map { |arr| arr.map { |int| int.to_s.center(max + 3)} } | ||
strings.each do |line| | ||
puts line.join.center(strings[-1].join.length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 (not 0) spaces for indentation.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
|
||
def print_triangle | ||
max = to_pascal.flatten.max.to_s.length | ||
strings = to_pascal.map { |arr| arr.map { |int| int.to_s.center(max + 3)} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space missing inside }.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
temp | ||
end | ||
|
||
def print_triangle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation detected.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
end | ||
end | ||
temp | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 16, 2 is not aligned with class at 1, 0.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
def to_pascal | ||
temp = [] | ||
@rows.times do |row| | ||
line = [1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 (not 0) spaces for indentation.
strings = to_pascal.map { |arr| arr.map { |int| int.to_s.center(max + 3)} } | ||
strings.each do |line| | ||
puts line.join.center(strings[-1].join.length) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 23, 2 is not aligned with strings.each do |line| at 21, 4.
2018/DmitryShkuratov/1/homework-1.rb
Outdated
temp << line | ||
end | ||
end | ||
temp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation detected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
подозрение на плагиат
Фамилия Имя
Дмитрий Шкуратов
Email
[email protected]
Номер домашнего задания
1
Ссылка на видео с демо работы
https://youtu.be/-stl_LHE4-k
Комментарии
nothing