Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Kaminari to pagy #4922

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Jul 24, 2024

Not quite ready for review yet

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.84%. Comparing base (0eb3e68) to head (b95ab01).
Report is 1 commits behind head on master.

Files Patch % Lines
app/views/oidc/providers/show_view.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4922      +/-   ##
==========================================
- Coverage   97.01%   95.84%   -1.18%     
==========================================
  Files         420      420              
  Lines        8724     8755      +31     
==========================================
- Hits         8464     8391      -73     
- Misses        260      364     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins force-pushed the segiddins/migrate-from-kaminari-to-pagy branch from f88a939 to 917e0b8 Compare August 27, 2024 15:25
@segiddins segiddins force-pushed the segiddins/migrate-from-kaminari-to-pagy branch from 917e0b8 to b95ab01 Compare August 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant