-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved the translation into Japanese #4149
improved the translation into Japanese #4149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot comment on translation accuracy because I cannot read Japanese. I tested the translations and they convert back to English exactly as expected. I will merge and we can follow up if it needs improvement.
It seems this only partially resolves the linked issue. |
Codecov Report
@@ Coverage Diff @@
## master #4149 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 279 279
Lines 6317 6317
=======================================
Hits 6247 6247
Misses 70 70 |
👍 |
* config/locales/ja.yml: Update Japanese translation for 64be113. Note that the message at downloads_amount is translated in ``improved the translation into Japanese rubygems#4149''[1]. [1] rubygems#4149
* config/locales/ja.yml: Update Japanese translation for 64be113. Note that the message at downloads_amount is translated in ``improved the translation into Japanese rubygems#4149''[1]. [1] rubygems#4149
* config/locales/ja.yml: Update Japanese translation for 64be113. Note that the message at downloads_amount is translated in ``improved the translation into Japanese rubygems#4149''[1]. [1] rubygems#4149
* Update Japanese translation for 64be113. * config/locales/ja.yml: Update Japanese translation for 64be113. Note that the message at downloads_amount is translated in ``improved the translation into Japanese #4149''[1]. [1] #4149 * Update Japanese translation for e00bb7f. * Update Japanese translation for 38be873. * Update Japanese translation for c87eb7d. * Update Japanese translation for 8907e31. * Update Japanese translation for 080b8e3. * Update Japanese translation for 5426292. * Remove messages according to d922ce6. * Update Japanese translation for b72b8cb. * Update Japanese translation for fafb028. * Update Japanese translation for 7e9a0d3. * Update Japanese translation for 9f72b07. * Update Japanese translation for 6a3c35c. * Update Japanese translation for 3be1f0b. * Update Japanese translation for 1d10606. * Remove message according to 2cd906f. * Update Japanese translation for e4a0d90. * Update Japanese translation for eaf9bef. * Translate on/off into Japanese. * config/locales/ja.yml: Translate on/off into Japanese. These are not translated in #3998. * Delete zero-width space in Japanese message. * config/locales/ja.yml (notifiers.show.info): Delete zero-width space in Japanese message. * Apply suggestions from code review Co-authored-by: OKURA Masafumi <[email protected]> --------- Co-authored-by: OKURA Masafumi <[email protected]>
This PR resolve #4042
before/after